From: Jasper St. Pierre <jstpierre@mecheye.net>
Date: Mon, 10 Dec 2012 08:58:59 +0000 (-0500)
Subject: overview: Clean up overview code
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~5260
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=e48dbe65f10ab6270d254da1c9e40314e73f0842;p=gnome-shell.git

overview: Clean up overview code

The comment here is a liar. We certainly can handle failure
using _syncInputMode().

https://bugzilla.gnome.org/show_bug.cgi?id=688589
---

diff --git a/js/ui/overview.js b/js/ui/overview.js
index da4dbae14..7780e8263 100644
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -434,12 +434,11 @@ const Overview = new Lang.Class({
             return;
         if (this._shown)
             return;
-        // Do this manually instead of using _syncInputMode, to handle failure
-        if (!Main.pushModal(this._group, { keybindingMode: Main.KeybindingMode.OVERVIEW }))
+        this._shown = true;
+        this._syncInputMode();
+        if (!this._modal)
             return;
-        this._modal = true;
         this._animateVisible();
-        this._shown = true;
     },
 
     fadeInDesktop: function() {